Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token support #504

Merged
merged 5 commits into from Oct 25, 2019
Merged

Token support #504

merged 5 commits into from Oct 25, 2019

Conversation

JoseAntonioTorre
Copy link
Contributor

Fixed changes advised by @almet in #500

Copy link
Member

@almet almet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, apart the typo.

)
decoded_resp = json.loads(resp.data.decode("utf-8"))
resp = self.client.get("/authenticate?token={}".format(decoded_resp["token"]))
# Test that We are readirected am redirected
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo : test that we are redirected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready @almet

@almet almet merged commit b683d06 into spiral-project:master Oct 25, 2019
Jojo144 pushed a commit to Jojo144/ihatemoney that referenced this pull request Mar 21, 2020
Added API support to generate authentication tokens, at `/api/projects/:id/token`
@zorun zorun added this to the v5 milestone Jul 17, 2020
TomRoussel pushed a commit to TomRoussel/ihatemoney that referenced this pull request Mar 2, 2024
Added API support to generate authentication tokens, at `/api/projects/:id/token`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants