Import previously exported json data #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is really appalling, do you mind adding a test for the upload_form? |
|
I can do that. |
|
I meant adding a test to make sure that importing a given json will create the project with the expected members and bills. |
|
I added a test as requested and also modified some of what I had done before. I realized that it was possible to search for a user that had been deactivated. At first, I considered that they were two different people |
almet
reviewed
Dec 24, 2019
|
Is there anything else I can do? |
Natim
reviewed
Jan 3, 2020
Natim
reviewed
Jan 3, 2020
Natim
reviewed
Jan 3, 2020
Natim
reviewed
Jan 3, 2020
Natim
reviewed
Jan 3, 2020
Natim
reviewed
Jan 3, 2020
Glandos
reviewed
Jan 4, 2020
Natim
approved these changes
Jan 12, 2020
Co-Authored-By: Rémy HUBSCHER <hubscher.remy@gmail.com>
Glandos
requested changes
Jan 13, 2020
Glandos
approved these changes
Jan 13, 2020
Glandos
reviewed
Jan 13, 2020
Jojo144
pushed a commit
to Jojo144/ihatemoney
that referenced
this pull request
Mar 21, 2020
Fix spiral-project#417 * New tab upload * Extract data from JSON * Add users * Black format * Try to add bill * Import bills * Add french translation msg * Black reformat missing * Deactivated users are supported * Test import * Remove temp file in upload_json() * Incomplete tests * tests import * Update ihatemoney/translations/fr/LC_MESSAGES/messages.po Co-Authored-By: Rémy HUBSCHER <hubscher.remy@gmail.com> * Remove useless variable and check json format * Use String.IO and test for wrong json * Remove coma Co-authored-by: Rémy HUBSCHER <hubscher.remy@gmail.com>
TomRoussel
pushed a commit
to TomRoussel/ihatemoney
that referenced
this pull request
Mar 2, 2024
Fix spiral-project#417 * New tab upload * Extract data from JSON * Add users * Black format * Try to add bill * Import bills * Add french translation msg * Black reformat missing * Deactivated users are supported * Test import * Remove temp file in upload_json() * Incomplete tests * tests import * Update ihatemoney/translations/fr/LC_MESSAGES/messages.po Co-Authored-By: Rémy HUBSCHER <hubscher.remy@gmail.com> * Remove useless variable and check json format * Use String.IO and test for wrong json * Remove coma Co-authored-by: Rémy HUBSCHER <hubscher.remy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to solve the issue #417, I added a tab to load a JSON, as well as a way to add the data found there, in an existing (or empty) project.
I realize that this was not the best way to manage the front end. But I couldn't add the form in the options section. So I did it like that to focus on the rest.
I had to add some messages, I have already noted their translation into French in
fr/LC_MESSAGES/messages.po