Bmatticus/feature/112 dashboard sorting #538
Conversation
…_table for dashboard. Issue spiral-project#112
…to initialize when table is not drawn.
… Dashboard, enabled paging again for now.
… can drill into project itself from the dashboard now and send invites.
|
That looks good to me. Any other feedback? |
|
Very nice improvement. I have one remark: is it possible to load CSS and JS only from dashboard? Right now, it will be loaded from every page, even if it will only be used for administration purposes. |
Yep, I can move it over. I was going to put it in the dashboard directly but most JS was being loaded in layout and I was trying to be consistent :) |
|
One other thing I was considering, should I remove the button/link on the project name and add a eye icon under actions to view the project? I think that may be more in line with the general feel. |
|
I am surprised that it works… I thought |
This is a good idea. The button seems a bit big in this table. Maybe keep a simple link on the project name, and add an eye button. The eye button will guide the user to the available action, and the link is just a shortcut for hurry people. |
… loading CSS/JS for datatables outside of the dashboard. Also added eye icon to drill into list_billa API to be more consistent with the look and feel of the overall site.
Yea, it should be in the <head> tag at least, it works either way but it is not proper. I used an if in the template to load only if the target is the dashboard for now. Also put the eye icon in place. |
|
All good :) Since @almet already approved this, let's enter the merge process. Thank you for your work on this, it's really appreciated. |
* Added DataTables for table sorting, pagination, and searching of bill_table for dashboard. Issue spiral-project#112 * Moved datatables CSS/JS to dashboard to reduce loaded data throughout * Moved link back to proper place, in head tab, but added if to prevent loading CSS/JS for datatables outside of the dashboard. Also added eye icon to drill into list_billa API to be more consistent with the look and feel of the overall site. Co-authored-by: bmatt <bmatt@nuc01.attlocal.net>
* Added DataTables for table sorting, pagination, and searching of bill_table for dashboard. Issue spiral-project#112 * Moved datatables CSS/JS to dashboard to reduce loaded data throughout * Moved link back to proper place, in head tab, but added if to prevent loading CSS/JS for datatables outside of the dashboard. Also added eye icon to drill into list_billa API to be more consistent with the look and feel of the overall site. Co-authored-by: bmatt <bmatt@nuc01.attlocal.net>
Added DataTables to Dashboard for sorting, pagination and filtering. Also made project name a link into the list_bills API to allow users to drill in directly to project to do other things from the dashboard. Feature #112