Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing release 5.0 #570

Closed
wants to merge 5 commits into from
Closed

Preparing release 5.0 #570

wants to merge 5 commits into from

Conversation

Natim
Copy link
Member

@Natim Natim commented Apr 24, 2020

Note that merging #571 before this means we should do a 5.0 major release because we remove Python 3.5 which is a breaking change.

@Natim Natim requested a review from Glandos April 24, 2020 07:21
@Natim Natim changed the title Preparing release 4.2 Preparing release 5.0 Apr 24, 2020
@zorun
Copy link
Collaborator

zorun commented Apr 24, 2020

Thanks for preparing this!

Here is a proposal for the changelog:

5.0 (unreleased)
================

Breaking changes
----------------

- Drop support for Python 2 (#483)
- Drop support for Python 3.5 (#571)

The minimum supported version is now Python 3.6

Added
-----

- Add espanol latino america (es_419) translation
- Add German translation (#492)
- Allow to import previously exported json data (#518)
- Add new optional field "external link" in bill form (#429)
- Add new statistics showing monthly expenses (#526)
- Add pagination to the list of bills (#480)
- Add sorting, pagination, and searching to the admin dashboard (#538)
- Add Project History page that records all changes (#553)
- Add token-based authentication to the API (#504)

Changed
-------

- Use the external debts lib to solve settlements (#476)
- Remove balance column in statistics view (#323)
- Remove requirements files in favor of setup.cfg pinning (#558)
- Make language choice persistent (#547)

Fixed
-----

- Improve input of email addresses when inviting people to join a project (#133)
- Fix datepicker that was displayed twice on some browsers (#221)

@zorun
Copy link
Collaborator

zorun commented Apr 24, 2020

Maybe the release should be done after fixing #553 (comment) and waiting for translations to be complete?

@Natim Natim force-pushed the prepare-4.2 branch 3 times, most recently from 073b3e1 to aec465e Compare April 25, 2020 11:13
@zorun
Copy link
Collaborator

zorun commented Apr 30, 2020

We should check whether the new Currency features (#541 ) changes the API and import/export in a backwards-compatible way. If not, we need to inform about it in "breaking changes".

Examples:

  • export a project with ihatemoney 4 and import it in ihatemoney 5
  • export a project with ihatemoney 5 and import it in ihatemoney 4
  • check that MoneyBuster is still happy with the API

If necessary, we could add some code for compatibility in the upcoming 4.1.4 (#588).

@Glandos
Copy link
Member

Glandos commented May 3, 2020

@zorun commented on 30 avr. 2020 à 13:56 UTC+2:

We should check whether the new Currency features (#541 ) changes the API and import/export in a backwards-compatible way. If not, we need to inform about it in "breaking changes".

For now, it's impossible to break, since the export doesn't export currencies. This seems a bug by the way, but it's a good time to think about it.

zorun pushed a commit to zorun/ihatemoney that referenced this pull request Jul 17, 2020
Since stable-4.1 only has backports, all its changes also apply to the
latest version and do not need to be repeated in 5.0.0
zorun pushed a commit that referenced this pull request Jul 17, 2020
Since stable-4.1 only has backports, all its changes also apply to the
latest version and do not need to be repeated in 5.0.0
@indatwood
Copy link
Contributor

Hey @Natim ! This seems to be conflicting related to translation files, could you update it? And then we could release 5.0!

@Glandos
Copy link
Member

Glandos commented Sep 4, 2021

@Natim I think you can just keep version number, since changelog entries were integrated (and augmented), and mo files were also updated since then. The conflicts should be resolved.

@@ -3,9 +3,9 @@
master_doc = "index"

project = "I hate money"
copyright = "2011, The 'I hate money' team"
copyright = "2011-2020, The 'I hate money' team"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 2021 now 😉

almet added a commit that referenced this pull request Oct 19, 2021
Based on the work done in #570 and #834 by @Natim and @Glandos.
almet added a commit that referenced this pull request Oct 19, 2021
Based on the work done in #570 and #834 by @Natim and @Glandos.
almet added a commit that referenced this pull request Oct 19, 2021
* Update changelog.

Based on the work done in #570 and #834 by @Natim and @Glandos.

* Update contributing.rst release instructions.

* Update documentation configuration.

* Update translations

* Update translation strings

* Preparing release 5.0.0

* Back to development: 5.0.1
@almet
Copy link
Member

almet commented Oct 19, 2021

Fixed in #866

@almet almet closed this Oct 19, 2021
@almet almet deleted the prepare-4.2 branch October 19, 2021 21:03
TomRoussel pushed a commit to TomRoussel/ihatemoney that referenced this pull request Mar 2, 2024
Since stable-4.1 only has backports, all its changes also apply to the
latest version and do not need to be repeated in 5.0.0
TomRoussel pushed a commit to TomRoussel/ihatemoney that referenced this pull request Mar 2, 2024
* Update changelog.

Based on the work done in spiral-project#570 and spiral-project#834 by @Natim and @Glandos.

* Update contributing.rst release instructions.

* Update documentation configuration.

* Update translations

* Update translation strings

* Preparing release 5.0.0

* Back to development: 5.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants