Improve project edit form #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glandos
reviewed
Jul 6, 2021
added 3 commits
July 7, 2021 01:01
The save() function is used to create a new project, so it belongs to the form creation class. Also clarify overriden form fields.
Currently, the private code is mandatory in the edit form, and it's not clear whether it's meant to **check** for the right private code or to **change** the private code. Make the field optional and rename the help message to make it clearer it's only meant to **change** the private code. Also change the field type to "password" instead of simple string.
zorun
pushed a commit
that referenced
this pull request
Jul 8, 2021
TomRoussel
pushed a commit
to TomRoussel/ihatemoney
that referenced
this pull request
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the private code is mandatory in the edit form, and it's not clear whether it's meant to check for the right private code or to change the private code.
Make the field optional and rename the help message to make it clearer it's only meant to change the private code.
Also change the field type to "password" instead of simple string, and refactor some code to clarify.