Rework flash messages #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spiral-project#903 They are now a macro, and can be called within other templates. This give the ability to fit them anywhere, at the cost of template complexity.
Peek.25-11-2021.12-42.mp4Peek.25-11-2021.12-43.mp4Peek.25-11-2021.12-44.mp4This is different from #903 (comment) since notifications can be after the navbar and the sidebar in mobile layout. |
|
Hey, since this doesn't change anything to how they appear (it seems, at least?) I wonder if you have a real use case for this change? |
|
In this PR, most of messages are now display after the sidebar, so on mobile, they are on top of bill list, and not on top of the participant list. In #903 (comment) the example works fine, because this is a small messages, and there is only one of it. If there are at least 2 messages with a long text, it will cover the screen anyway, and it seems to me to be a better place to integrate it in the |
|
Okay, your call: it seems you put more thoughts than me on this one ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #903
They are now a macro, and can be called within other templates.
This give the ability to fit them anywhere, at the cost of template complexity.