[maintenance]: optimize token for Postgre #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
============================================
+ Coverage 66.90% 67.18% +0.27%
- Complexity 420 423 +3
============================================
Files 51 51
Lines 1097 1103 +6
============================================
+ Hits 734 741 +7
+ Misses 363 362 -1
Continue to review full report at Codecov.
|
|
Hi @Eugentis ! Thank you for PR. Could you please cover it with unit tests? |
|
I am not sure I can provide tests for bytea fields (Postgre).... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current state you can use getPayload method for Token only once - stream exists only for first call.
It is not correct. It is possible to use optimized structure