Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding scopes and other improvements #16

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Mar 7, 2024

  • Waiting for release scopes in spiral/framework and spiral/testing
  • Need to fix spiral/framework and spiral/testing versions in composer.json

What was changed

  • Added binding of Spiral\DataGrid\InputInterface to Spiral\DataGrid\GridInput in the http.request scope, as GridInput requires Spiral\Http\Request\InputManager in its dependencies, which is only available in http.request. Added binding of Proxy InputInterface in the root scope.

  • Added unit tests for bindings, updated PHPUnit to v10.5.

  • Updated Psalm to 5.22, decreased Psalm level from 4 to 2.

@msmakouz msmakouz self-assigned this Mar 7, 2024
@msmakouz msmakouz added the enhancement New feature or request label Mar 7, 2024
@msmakouz msmakouz marked this pull request as draft March 7, 2024 15:06
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 20.37%. Comparing base (29e8b7c) to head (07d1a57).

Files Patch % Lines
src/Interceptor/GridInterceptor.php 0.00% 3 Missing ⚠️
src/Response/GridResponse.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master      #16       +/-   ##
=============================================
+ Coverage      3.19%   20.37%   +17.17%     
- Complexity       39       41        +2     
=============================================
  Files             7        6        -1     
  Lines            94      108       +14     
=============================================
+ Hits              3       22       +19     
+ Misses           91       86        -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants