Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Code Quality】Use PHP-CS-Fixer automatically fix PHP Coding Standards #215

Closed
charescape opened this issue Sep 21, 2019 · 1 comment
Closed

Comments

@charescape
Copy link

PHP Coding Standards Fixer https://cs.symfony.com/

example1:

// before
$request->getUri()->getScheme() == "https"

// after
$request->getUri()->getScheme() === 'https'

example2:

// before
final class Environment implements EnvironmentInterface
{
    const VALUE_MAP = [...];
    ...
}

// after
final class Environment implements EnvironmentInterface
{
    public const VALUE_MAP = [...];
    ...
}

example3:

// before
final class CookiesMiddleware implements MiddlewareInterface
{
    private $config = null;

    private $scope = null;

    private $encryption = null;

    ...
}

// after
final class CookiesMiddleware implements MiddlewareInterface
{
    private $config;

    private $scope;

    private $encryption;

    ...
}
@wolfy-j
Copy link
Member

wolfy-j commented Oct 11, 2019

Done!

@wolfy-j wolfy-j closed this as completed Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants