Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spiral/reactor] Up min version of nette/php-generator #1014

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC?
New feature?

The problem that caused us to fix the version has been fixed in 4.1.2.

@msmakouz msmakouz added this to the 3.9 milestone Nov 15, 2023
@msmakouz msmakouz self-assigned this Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85aa4bb) 89.15% compared to head (32c7b6a) 89.14%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1014      +/-   ##
============================================
- Coverage     89.15%   89.14%   -0.01%     
  Complexity     6124     6124              
============================================
  Files           812      812              
  Lines         17312    17312              
============================================
- Hits          15434    15433       -1     
- Misses         1878     1879       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster merged commit 6714d80 into master Nov 15, 2023
12 checks passed
@butschster butschster deleted the maintenance/nette-php-generator branch November 15, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants