[spiral/router] Opening of http.request scope added
#1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/scopes #1069 +/- ##
====================================================
- Coverage 89.53% 89.49% -0.04%
- Complexity 6318 6327 +9
====================================================
Files 824 825 +1
Lines 17799 17831 +32
====================================================
+ Hits 15936 15958 +22
- Misses 1863 1873 +10 ☔ View full report in Codecov by Sentry. |
wolfy-j
reviewed
Jan 25, 2024
| return $this->app->getHttp()->handle( | ||
| $this->request($uri, 'POST', [], $headers, $cookies)->withParsedBody($data) | ||
| return $this->app->getContainer()->runScope( | ||
| new Scope(ScopeName::Http), |
There was a problem hiding this comment.
we will come up with better name for the enum before release
wolfy-j
reviewed
Jan 25, 2024
wolfy-j
reviewed
Jan 25, 2024
wolfy-j
reviewed
Jan 25, 2024
msmakouz
force-pushed
the
feature/http-request-scope
branch
from
6117455
to
dd40fb1
Compare
msmakouz
force-pushed
the
feature/http-request-scope
branch
from
dd40fb1
to
a82dcfe
Compare
roxblnfk
reviewed
Jan 25, 2024
roxblnfk
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Opening of
http.requestscope added,Proxyattributes added to get dependencies in the correct scope.