Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spiral/core] Added checking parent scopes before throwing an exception #1076

Merged
merged 4 commits into from
Feb 15, 2024
Merged

[spiral/core] Added checking parent scopes before throwing an exception #1076

merged 4 commits into from
Feb 15, 2024

Conversation

msmakouz
Copy link
Member

Q A
Bugfix? ✔️
Breaks BC? ❌
New feature? ❌

@msmakouz msmakouz added this to the 3.12 milestone Feb 15, 2024
@msmakouz msmakouz self-assigned this Feb 15, 2024
@msmakouz msmakouz changed the title Add checking parent scopes [spiral/code] Added checking parent scopes before throwing an exception Feb 15, 2024
@msmakouz msmakouz changed the title [spiral/code] Added checking parent scopes before throwing an exception [spiral/core] Added checking parent scopes before throwing an exception Feb 15, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dfb4061) 89.54% compared to head (ed83d80) 89.54%.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1076   +/-   ##
=========================================
  Coverage     89.54%   89.54%           
  Complexity     6335     6335           
=========================================
  Files           827      827           
  Lines         17877    17879    +2     
=========================================
+ Hits          16008    16010    +2     
  Misses         1869     1869

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msmakouz msmakouz added the Bug label Feb 15, 2024
@msmakouz msmakouz mentioned this pull request Feb 15, 2024
Merged
@roxblnfk roxblnfk merged commit 96cf3f3 into master Feb 15, 2024
13 of 14 checks passed
@roxblnfk roxblnfk deleted the bugfix/parent-scopes branch February 15, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxblnfk roxblnfk roxblnfk approved these changes

@butschster butschster Awaiting requested review from butschster

Assignees

@msmakouz msmakouz

Labels
Bug Component: Core
Projects
Spiral framework
Status: Done
Milestone
3.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msmakouz @roxblnfk