Added PaginationProviderInterface binding in scope
#1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/scopes #1079 +/- ##
=================================================
Coverage 89.53% 89.54%
- Complexity 6346 6350 +4
=================================================
Files 828 829 +1
Lines 17911 17926 +15
=================================================
+ Hits 16037 16052 +15
Misses 1874 1874 ☔ View full report in Codecov by Sentry. |
roxblnfk
approved these changes
Feb 16, 2024
| use Spiral\Pagination\PaginationProviderInterface; | ||
| use Spiral\Pagination\Paginator; | ||
| use Spiral\Pagination\PaginatorInterface; | ||
|
|
||
| /** | ||
| * Paginators factory binded to active request scope in order to select page number. | ||
| */ | ||
| #[Scope(Spiral::HttpRequest)] |
There was a problem hiding this comment.
Note
this attribute will be breaking change in the case when the user requests the implementation directly, not via interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaginationProviderInterface binding has been moved to http.request scope. Until version 4.0, binding in the root scope with the display of deprecation message still available.