Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reading annotations by default #1087

Merged
merged 4 commits into from Feb 29, 2024

Conversation

msmakouz
Copy link
Member

Q A
Bugfix? ✔️
Breaks BC?
New feature?

The default reading of annotations has been reverted. After updating the framework to version 3.12.0, need to explicitly add the doctrine/annotations dependency to a project to enable annotations. No settings need to be changed. Annotations will be completely removed in version 4.0.

@msmakouz msmakouz added this to the 3.12 milestone Feb 26, 2024
@msmakouz msmakouz self-assigned this Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.62%. Comparing base (dd46fbf) to head (fcde1a4).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1087      +/-   ##
============================================
+ Coverage     89.60%   89.62%   +0.02%     
  Complexity     6346     6346              
============================================
  Files           829      829              
  Lines         17905    17905              
============================================
+ Hits          16043    16048       +5     
+ Misses         1862     1857       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster merged commit 82ece5f into master Feb 29, 2024
14 checks passed
@butschster butschster deleted the bugfix/enable-annotations-by-default branch February 29, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants