[Rector] Apply SetList::DEAD_CODE #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
commented
Nov 11, 2021
samsonasik
force-pushed
the
apply-dead-code-setlist
branch
from
51abfa7
to
e339791
Compare
|
I will look into the errors, possibly skip rector rules that cause it. |
samsonasik
commented
Nov 11, 2021
samsonasik
commented
Nov 11, 2021
…anceof InjectorInterface next
samsonasik
commented
Nov 11, 2021
samsonasik
commented
Nov 11, 2021
Codecov Report
@@ Coverage Diff @@
## 2.8 #472 +/- ##
============================================
+ Coverage 84.25% 84.28% +0.02%
+ Complexity 8754 8752 -2
============================================
Files 1192 1192
Lines 29793 29783 -10
============================================
Hits 25102 25102
+ Misses 4691 4681 -10
Continue to review full report at Codecov.
|
|
@butschster all green 🎉 |
samsonasik
commented
Nov 11, 2021
butschster
reviewed
Nov 12, 2021
| * form of a bitmask indicating the places where attributes | ||
| * can be defined. | ||
| */ | ||
| public function __construct( |
There was a problem hiding this comment.
@roxblnfk what do you think. Is this piece of code required?
There was a problem hiding this comment.
Now this code is dead. Mb is it mistake?
|
@samsonasik hi! Sorry for long response. We didn't forget about your your PR, this week I'll try to check it and merge! Thank you! |
butschster
reviewed
Dec 23, 2021
butschster
reviewed
Dec 23, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply Rector's
SetList::DEAD_CODESetlist to remove unnecessary code.Mostly applied changes:
Complete lists are at https://github.com/rectorphp/rector-src/blob/6a8d8233b963f3361383ce7a76a343be16837bff/config/set/dead-code.php