Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Encrypter code with PHP 8.1 features #624

Merged
merged 6 commits into from
Apr 1, 2022
Merged

Updating Encrypter code with PHP 8.1 features #624

merged 6 commits into from
Apr 1, 2022

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC? ✔️
New feature?
Issues #512

@msmakouz msmakouz added this to the 3.0 milestone Mar 25, 2022
@msmakouz msmakouz requested a review from roxblnfk March 25, 2022 16:33
@msmakouz msmakouz self-assigned this Mar 25, 2022
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #624 (2e59399) into 3.0 (3048674) will decrease coverage by 0.00%.
The diff coverage is 94.02%.

@@             Coverage Diff              @@
##                3.0     #624      +/-   ##
============================================
- Coverage     82.64%   82.63%   -0.01%     
+ Complexity     5818     5810       -8     
============================================
  Files           667      667              
  Lines         14655    14643      -12     
============================================
- Hits          12111    12100      -11     
+ Misses         2544     2543       -1     
Impacted Files Coverage Δ
src/Dumper/src/helpers.php 0.00% <0.00%> (ø)
src/Dumper/src/Dumper.php 91.59% <94.59%> (-0.21%) ⬇️
src/Dumper/src/Renderer/AbstractRenderer.php 75.00% <100.00%> (ø)
src/Dumper/src/Renderer/ConsoleRenderer.php 90.90% <100.00%> (-1.95%) ⬇️
src/Dumper/src/Renderer/HtmlRenderer.php 94.44% <100.00%> (+3.53%) ⬆️
src/Dumper/src/Renderer/PlainRenderer.php 100.00% <100.00%> (ø)
src/Encrypter/src/Encrypter.php 84.61% <100.00%> (ø)
src/Encrypter/src/EncrypterFactory.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27ed325...2e59399. Read the comment docs.

@roxblnfk roxblnfk merged commit 4fa01d1 into spiral:3.0 Apr 1, 2022
@msmakouz msmakouz deleted the maintenance/encrypter-php-81 branch April 4, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants