Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating HMVC code with PHP 8.1 features #628

Merged
merged 4 commits into from
Apr 1, 2022
Merged

Updating HMVC code with PHP 8.1 features #628

merged 4 commits into from
Apr 1, 2022

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC? ✔️
New feature?
Issues #512

@msmakouz msmakouz requested a review from roxblnfk March 27, 2022 10:49
@msmakouz msmakouz self-assigned this Mar 27, 2022
@msmakouz msmakouz added this to the 3.0 milestone Mar 27, 2022
@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #628 (3549921) into 3.0 (eb7288d) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0     #628      +/-   ##
============================================
- Coverage     82.53%   82.42%   -0.12%     
+ Complexity     5779     5756      -23     
============================================
  Files           667      665       -2     
  Lines         14487    14151     -336     
============================================
- Hits          11957    11664     -293     
+ Misses         2530     2487      -43     
Impacted Files Coverage Δ
src/Hmvc/src/AbstractCore.php 100.00% <100.00%> (ø)
src/Hmvc/src/InterceptableCore.php 100.00% <100.00%> (ø)
src/Hmvc/src/InterceptorPipeline.php 100.00% <100.00%> (ø)
src/Framework/Bootloader/AttributesBootloader.php 60.00% <0.00%> (-3.64%) ⬇️
src/Exceptions/src/HtmlHandler.php 71.73% <0.00%> (-3.27%) ⬇️
src/Validation/src/Condition/Compositor.php 85.71% <0.00%> (-3.18%) ⬇️
...Framework/Bootloader/Storage/StorageBootloader.php 70.00% <0.00%> (-2.73%) ⬇️
src/Exceptions/views/exception.php 76.47% <0.00%> (-2.70%) ⬇️
src/Router/src/RouteGroup.php 86.11% <0.00%> (-1.99%) ⬇️
...Scaffolder/src/Bootloader/ScaffolderBootloader.php 80.95% <0.00%> (-1.66%) ⬇️
... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7288d...3549921. Read the comment docs.

@roxblnfk roxblnfk merged commit 541117d into spiral:3.0 Apr 1, 2022
@msmakouz msmakouz deleted the maintenance/hmvc-php-81 branch April 4, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants