Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes dumper component #679

Merged
merged 3 commits into from
May 4, 2022
Merged

Removes dumper component #679

merged 3 commits into from
May 4, 2022

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented May 2, 2022

Also remove HtmlRenderer -- we will use https://github.com/spiral-packages/ignition-bridge instead

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #679 (e08c977) into 3.0 (1ca0ee8) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.0     #679      +/-   ##
============================================
+ Coverage     82.06%   82.13%   +0.06%     
+ Complexity     5492     5377     -115     
============================================
  Files           623      605      -18     
  Lines         13755    13354     -401     
============================================
- Hits          11288    10968     -320     
+ Misses         2467     2386      -81     
Impacted Files Coverage Δ
src/Boot/src/Bootloader/CoreBootloader.php 100.00% <ø> (ø)
...ramework/Bootloader/ExceptionHandlerBootloader.php 100.00% <ø> (ø)
src/Framework/helpers.php 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ca0ee8...e08c977. Read the comment docs.

@roxblnfk roxblnfk requested a review from butschster May 2, 2022 14:34
@butschster butschster changed the title Desintegrate dumper component Removes dumper component May 4, 2022
@butschster butschster merged commit c9d3d11 into 3.0 May 4, 2022
@butschster butschster linked an issue May 4, 2022 that may be closed by this pull request
@roxblnfk roxblnfk deleted the desintegrate-dumper-component branch May 5, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dumper] Replace Dumper component with Symfony
2 participants