Fixes problem when paginator doesn't calculate countPages
correctly in constructor
#928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the
Paginator
class has an issue in the constructor when we pass the$count
argument. The problem is with the$countPages
property which should be calculated based on the$count
property, but it doesn't. This can cause incorrect pagination calculations. To solve this issue, I have updated thePaginator
constructor to invoke thesetCount
method with the$count
argument, ensuring that the$countPages
property is recalculated correctly.