Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect Concatenation of Route Pattern with Prefix in Route Group #967

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

butschster
Copy link
Member

See #962

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (32ce0e6) 83.73% compared to head (ce47614) 83.73%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #967   +/-   ##
=========================================
  Coverage     83.73%   83.73%           
  Complexity     6038     6038           
=========================================
  Files           793      793           
  Lines         17007    17010    +3     
=========================================
+ Hits          14240    14243    +3     
  Misses         2767     2767           
Files Changed Coverage Δ
src/Router/src/UriHandler.php 94.96% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster merged commit 5e483c4 into master Aug 16, 2023
12 checks passed
@butschster butschster modified the milestones: 3.9, 3.8 Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[spiral/router] Incorrect Concatenation of Route Pattern with Prefix in Route Group
2 participants