Adding force parameter to the bindSingleton method
#973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
=========================================
Coverage 83.74% 83.74%
- Complexity 6040 6041 +1
=========================================
Files 793 793
Lines 17019 17021 +2
=========================================
+ Hits 14253 14255 +2
Misses 2766 2766
☔ View full report in Codecov by Sentry. |
butschster
approved these changes
Aug 17, 2023
roxblnfk
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added the force parameter to the
bindSingletonmethod with a default value of true. This ensures that the behavior remains unchanged in the minor version. In the major version v4.0.0, the parameter can be removed or set to true by default.