Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking singletons in the hasInstance method #975

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Aug 29, 2023

Q A
Bugfix? ✔️
Breaks BC?
New feature?

What was changed

The make method on the Spiral\Core\Internal\Factory class removes the requested alias from the bindings array if it is a singleton. In the hasInstance method of the Spiral\Core\Internal\Config\StateBinder class, need to check the singletons array.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (ad0a0c5) 83.74% compared to head (55c4df8) 83.73%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #975      +/-   ##
============================================
- Coverage     83.74%   83.73%   -0.01%     
- Complexity     6041     6042       +1     
============================================
  Files           793      793              
  Lines         17021    17023       +2     
============================================
  Hits          14255    14255              
- Misses         2766     2768       +2     
Files Changed Coverage Δ
src/Core/src/Internal/Config/StateBinder.php 84.33% <100.00%> (-0.85%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster added this to the 3.8 milestone Aug 29, 2023
@butschster butschster merged commit f87c9b5 into spiral:master Aug 29, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants