Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing visibility in the Storage configuration #977

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Aug 31, 2023

Q A
Bugfix? ✔️
Breaks BC?
New feature?

What was changed

  1. Fixed a typo in the Storage configuration file, added tests for it.
  2. Updated Rector.

@msmakouz msmakouz self-assigned this Aug 31, 2023
@msmakouz msmakouz added this to the 3.9 milestone Aug 31, 2023
@msmakouz msmakouz changed the title Fixing **visibility** in the Storage configuration Fixing visibility in the Storage configuration Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14% 🎉

Comparison is base (8aeef4c) 83.74% compared to head (8078820) 83.88%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #977      +/-   ##
============================================
+ Coverage     83.74%   83.88%   +0.14%     
  Complexity     6042     6042              
============================================
  Files           793      793              
  Lines         17023    17023              
============================================
+ Hits          14256    14280      +24     
+ Misses         2767     2743      -24     
Files Changed Coverage Δ
src/Storage/src/Bucket/WritableTrait.php 0.00% <ø> (ø)
src/Tokenizer/src/Reflection/ReflectionFile.php 95.16% <ø> (ø)
src/Translator/src/Traits/TranslatorTrait.php 100.00% <ø> (ø)
src/Storage/src/Config/StorageConfig.php 54.28% <100.00%> (+17.85%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msmakouz msmakouz marked this pull request as draft August 31, 2023 13:26
@msmakouz msmakouz marked this pull request as ready for review August 31, 2023 13:33
@msmakouz msmakouz modified the milestones: 3.9, 3.8 Aug 31, 2023
@butschster butschster merged commit 2f631b2 into spiral:master Sep 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants