Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spiral/core] Added checking hasInstance in the parent scope #981

Merged
merged 4 commits into from
Sep 6, 2023
Merged

[spiral/core] Added checking hasInstance in the parent scope #981

merged 4 commits into from
Sep 6, 2023

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Sep 5, 2023

Q A
Bugfix? ❌
Breaks BC? ❌
New feature? ❌
Issues #976

@msmakouz msmakouz self-assigned this Sep 5, 2023
@msmakouz msmakouz marked this pull request as draft September 5, 2023 06:39
@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06% ⚠️

Comparison is base (2f631b2) 83.89% compared to head (65e361c) 83.83%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #981      +/-   ##
============================================
- Coverage     83.89%   83.83%   -0.06%     
- Complexity     6042     6048       +6     
============================================
  Files           793      793              
  Lines         17023    17046      +23     
============================================
+ Hits          14281    14291      +10     
- Misses         2742     2755      +13
Files Changed Coverage Δ
src/Core/src/Internal/Binder.php 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msmakouz msmakouz changed the title [spiral/code] Adding hasInstance Scoped tests [spiral/code] Added checking hasInstance in the parent scope Sep 5, 2023
@msmakouz msmakouz added this to the 3.8 milestone Sep 5, 2023
@msmakouz msmakouz linked an issue Sep 5, 2023 that may be closed by this pull request
[spiral/core] Add HasInstance Scoped tests #976
Closed
@msmakouz msmakouz marked this pull request as ready for review September 5, 2023 07:15
@roxblnfk roxblnfk changed the title [spiral/code] Added checking hasInstance in the parent scope [spiral/core] Added checking hasInstance in the parent scope Sep 5, 2023
@butschster butschster merged commit efb130d into spiral:master Sep 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butschster butschster butschster approved these changes

@roxblnfk roxblnfk roxblnfk approved these changes

Assignees

@msmakouz msmakouz

Labels
Bug Component: Core
Projects
Spiral framework
Status: Done
Milestone
3.8
Development

Successfully merging this pull request may close these issues.

[spiral/core] Add HasInstance Scoped tests
3 participants
@msmakouz @butschster @roxblnfk