Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codec): add new codec with proto requests/responses support #122

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

rustatian
Copy link
Member

Reason for This PR

  • Add new codec support

Description of Changes

  • Add support for the CODEC_PROTO with number 0x80 in the protocol frame

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s) or (git commit -S).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
- Use GOB as default codec for nil message

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #122 (65898f6) into master (311cfcf) will decrease coverage by 4.07%.
The diff coverage is 47.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   59.50%   55.42%   -4.08%     
==========================================
  Files           8        9       +1     
  Lines         363      525     +162     
==========================================
+ Hits          216      291      +75     
- Misses        123      201      +78     
- Partials       24       33       +9     
Impacted Files Coverage Δ
test/message.pb.go 36.52% <36.52%> (ø)
pkg/rpc/decoders.go 24.48% <45.45%> (+6.06%) ⬆️
pkg/rpc/encoders.go 18.18% <50.00%> (+7.07%) ⬆️
pkg/rpc/codec.go 58.77% <59.09%> (+2.04%) ⬆️
pkg/rpc/client.go 74.68% <85.18%> (+4.19%) ⬆️
internal/receive.go 80.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 311cfcf...65898f6. Read the comment docs.

@rustatian rustatian added this to the 3.1.0 milestone Jun 9, 2021
@rustatian rustatian merged commit cd7ec57 into master Jun 9, 2021
@bors bors bot deleted the feature/new_proto_codec branch June 9, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants