Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG, RR1] "max allowed memory reached" should not be reported as ERROR #359

Closed
hugochinchilla opened this issue Sep 8, 2020 · 3 comments
Closed

[BUG, RR1] "max allowed memory reached" should not be reported as ERROR #359

hugochinchilla opened this issue Sep 8, 2020 · 3 comments
Assignees
@rustatian
Labels
B-bug Bug: bug, exception F-need-verification help-needed-easy Call for participation: Experience needed to fix: Easy / not much Y-Low Priority: Low

Comments

@hugochinchilla
Copy link

When maxMemory is reached a line is written to the logs as ERROR, as the maxMemory is a soft limit it should be treated as an INFO or a NOTICE.
@rustatian rustatian added this to the unplanned milestone Sep 8, 2020
@rustatian
Copy link
Member

@hugochinchilla I am going to agree with you. Would you mind to make a PR?

@rustatian rustatian modified the milestones: unplanned, 1.8.4 Sep 8, 2020
@rustatian rustatian modified the milestones: 1.8.4, next Oct 21, 2020
@hugochinchilla
Copy link
Author

@48d90782 I'm sorry for the late reply, I'm not familiar with golang but this did not prevent me from taking a look at the source code to see if it was possible with my limited knlowledge, sadly I don't know how to do it.

@rustatian
Copy link
Member

@48d90782 I'm sorry for the late reply, I'm not familiar with golang but this did not prevent me from taking a look at the source code to see if it was possible with my limited knlowledge, sadly I don't know how to do it.

Got you 😃 Likely we will update RR 2.0 first and then I return back to the 1.x version. Thanks for the proposal 😃

@rustatian rustatian added the Y-Low Priority: Low label Nov 30, 2020
@rustatian rustatian added the help-needed-easy Call for participation: Experience needed to fix: Easy / not much label Jan 18, 2021
@rustatian rustatian removed this from the next milestone Mar 28, 2021
@rustatian rustatian changed the title [BUG] "max allowed memory reached" should not be reported as ERROR [BUG, RR1] "max allowed memory reached" should not be reported as ERROR May 20, 2021
@vladimirdotk vladimirdotk mentioned this issue Aug 10, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustatian rustatian

Labels
B-bug Bug: bug, exception F-need-verification help-needed-easy Call for participation: Experience needed to fix: Easy / not much Y-Low Priority: Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(plugin): worker max memory reached reported as warning
3 participants
@hugochinchilla @rustatian @dpodoliak