Moved CI to GH Actions. #14
Conversation
|
I'm not sure why the codecov comment and checks are missing, but I activated the coveralls comment and set a minimum of 80% coverage for success and a max. 5% coverage decrease. |
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=========================================
Coverage ? 52.22%
=========================================
Files ? 8
Lines ? 1779
Branches ? 0
=========================================
Hits ? 929
Misses ? 850
Partials ? 0 |
MSallermann
force-pushed
the
gh_actions
branch
6 times, most recently
from
a7ee7a9
to
e0b87de
Compare
|
I think I made all the requested changes. https://github.com/spirit-code/ovf/pull/14/checks?check_run_id=3309330205 |
There was a problem hiding this comment.
Looks like coveralls should be called a little differently. Right now, it is also calculating the coverage of the python/test folder: https://coveralls.io/github/spirit-code/ovf?branch=gh_actions
Looking at https://github.com/spirit-code/spirit/blob/develop/.github/workflows/ci.yml#L117-L126, I think the coverage call should be
coverage run --source ovf --omit=ovf/ovflib.py setup.py test > cov.txt
- removed superfluous openmp line - added fortran build on ubuntu - added rocket icon to deploy step name - more consistent naming of steps
MSallermann
force-pushed
the
gh_actions
branch
from
e0b87de
to
ba6cab7
Compare
`c_f_pointer` does not assign a length to the ponted-to character string `f_ptr`, so that debug builds (with bounds checks) cause a "substring out of bounds" error when accessing `f_ptr` to assign it to `f_string`. `f_ptr` is now an array and `c_f_pointer` gets passed the shape that should be assigned. The array is then read into the `f_string` string in a do-loop.
Replaces the travis and appveyor CI with github actions.
Includes coverage and pypi deployment and also adds windows builds, which were previously not covered.
Branched from master, since it is ahead of develop.