This repository has been archived by the owner on Jan 20, 2018. It is now read-only.
Added support for 'SLOT ###' disk references #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis CI errors due to missing openstack api keys - same as errors on #11 |
|
Spec tests!! ❤️ Yeah Travis only allows my user to decrypt the keys hence they fail, can't have some naughty code echoing out my details :) I'll take a look soon. I really wish the driver devs would standardize their sysfs implementations... |
|
Do you mean the Travis keys issue gets in the way of spec tests? I'm fairly new to this setup - only ever submitted a couple of PRs. |
This matches the ceph::keyring class parameters
Make ceph.conf template idempotent by sorting hash keys
package options
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to 'Slot ##' and 'DISK##'.
On our (IBM xSeries) hardware, we have e.g.
/sys/class/enclosure/0:0:8:0/SLOT 000/device/block/sda