馃摝 馃殤 Fixed a problem with multi-events + pandas version #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebuilding production was incorrectly distributed in multiple events simulation, leading to more capital being rebuilt than what was possible. This is now fixed. Also, I loosened the restriction on pandas version.
spjuhel
added a commit
that referenced
this pull request
Feb 24, 2024
* 0.5.2 patch (#64) * (Extended models) :fix: Attempt at fixing #62 Should fix #62 * Fix final demand only NaN * fix (simulation.py) : typo for final demand record * bump dep versions * Fix (event.py) : Household rebuilding NaN corrected (#65) * version bump 0.5.3 * 馃殤 (event) : Working fix for household rebuilding demand * 馃拕 Black * update website * 馃摝 馃殤 Fixed a problem with multi-events + pandas version (#66) Rebuilding production was incorrectly distributed in multiple events simulation, leading to more capital being rebuilt than what was possible. This is now fixed. Also, I loosened the restriction on pandas version. * Create draft-pdf.yml (#71) * 馃摝 馃 Paper.md ! * update paper.md * added some refs to paper * pre submission update * papers typos * missing doi + no double brackets * correct ref
spjuhel
added a commit
that referenced
this pull request
Feb 24, 2024
* 0.5.2 patch (#64) * (Extended models) :fix: Attempt at fixing #62 Should fix #62 * Fix final demand only NaN * fix (simulation.py) : typo for final demand record * bump dep versions * Fix (event.py) : Household rebuilding NaN corrected (#65) * version bump 0.5.3 * 馃殤 (event) : Working fix for household rebuilding demand * 馃拕 Black * update website * 馃摝 馃殤 Fixed a problem with multi-events + pandas version (#66) Rebuilding production was incorrectly distributed in multiple events simulation, leading to more capital being rebuilt than what was possible. This is now fixed. Also, I loosened the restriction on pandas version. * Create draft-pdf.yml (#71) * 馃摝 馃 Paper.md ! * update paper.md * added some refs to paper * pre submission update * papers typos * missing doi + no double brackets * correct ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuilding production was incorrectly distributed in multiple events simulation, leading to more capital being rebuilt than what was possible. This is now fixed. Also, I loosened the restriction on pandas version.