Use monetize
as a development dependency only
#50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all 馃憢
Thank you for useful library!
I just noticed unnecessary extra dependencies in the my project after I started to use this gem - it was
monetize
gem and it does nothing useful into this gem, neither into my project. So I assume it would be better to use this gem as a development/test dependency only.I have checked all the test w/o
monetize
as well. It is used in two places:money-open-exchange-rates/test/open_exchange_rates_bank_test.rb
Line 107 in 4959d1f
money-open-exchange-rates/test/open_exchange_rates_bank_test.rb
Line 126 in 4959d1f
It's quite simple to use
Money.from_amount
here and do not have an extra dependency with a dozen of monkey-patches 馃檲What do you think, guys?