Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use monetize as a development dependency only #50

Merged
merged 1 commit into from Mar 30, 2018

Conversation

v-kolesnikov
Copy link
Contributor

Hi all 馃憢

Thank you for useful library!

I just noticed unnecessary extra dependencies in the my project after I started to use this gem - it was monetize gem and it does nothing useful into this gem, neither into my project. So I assume it would be better to use this gem as a development/test dependency only.

I have checked all the test w/o monetize as well. It is used in two places:

subject.exchange_with(5000.to_money('WTF'), 'USD').cents.wont_equal 0

subject.exchange_with(100.to_money('BTC'), 'USD').cents.must_equal 137_603

It's quite simple to use Money.from_amount here and do not have an extra dependency with a dozen of monkey-patches 馃檲

What do you think, guys?

@spk
Copy link
Owner

spk commented Mar 30, 2018

Hi @v-kolesnikov you are completely right about the extra dependency I did that mistake when updating money here 7d35ee2 thanks

@spk spk merged commit cac8eb3 into spk:master Mar 30, 2018
@v-kolesnikov v-kolesnikov deleted the fix/avoid-monetize branch March 30, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants