New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unclosed file descriptor after read_from_cache #65

Merged

spk merged 1 commit into spk:master from korun:ensure-file-closed

Sep 7, 2020

Contributor

korun commented Sep 3, 2020

Subj, IO.read ensures the file is closed before returning, while File.open(...).read leave unclosed descriptor.


          Fix unclosed file descriptor after read_from_cache

e693585

spk approved these changes

View reviewed changes

Owner

spk left a comment

You're right nice catch thanks!

spk merged commit 4dc5ab9 into spk:master

korun deleted the ensure-file-closed branch

September 11, 2020 10:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment