Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have 'Completed builds' list show the repo the new builds are in #1049

Open
dcookspi opened this issue Jun 14, 2024 · 2 comments
Open

Have 'Completed builds' list show the repo the new builds are in #1049

dcookspi opened this issue Jun 14, 2024 · 2 comments
Labels
enhancement New feature or request SPI AOI Area of interest for SPI SPI-0.41

Comments

@dcookspi
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Some users would like to see the repo name included in the list of Completed builds shown at the end of an spk build, e.g. local/mypackagethatjustbuild/S0M3BU1LDID. It will make it clear where the builds ended up and save them having to add the repo name when they want to copy and paste a build id line.

Describe the solution you'd like
spk build currently finishes with output like this:

Completed builds:
   mypkg/0.3.0/src
   mypkg/0.3.0/LWWC62UL variant index 0, ...
   ...

We'd like it to look like this instead:

Completed builds:
   local/mypkg/0.3.0/src
   local/mypkg/0.3.0/LWWC62UL variant index 0, ...
   ...

Additional context
I had a quick look and it'll involve something like turning the BuildIdents returned from the binary build method into LocatedBuildIdents to keep the repo with the build, adjusting the BuildResult enum to contain them, and then adjusting their display to include their repo name.

@dcookspi dcookspi added agenda item Items to be brought up at the next dev meeting enhancement New feature or request SPI AOI Area of interest for SPI SPI-0.41 labels Jun 14, 2024
@dcookspi dcookspi changed the title Have completed builds list show the repo the new builds are in Have 'Completed builds' list show the repo the new builds are in Jun 14, 2024
@rydrman
Copy link
Collaborator

rydrman commented Jun 15, 2024

Are the builds not always stored in the local repo?

@dcookspi
Copy link
Collaborator Author

Are the builds not always stored in the local repo?

They are, but I think the users would like to not have to type local/ when copying the build identifiers around,

@dcookspi dcookspi removed the agenda item Items to be brought up at the next dev meeting label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SPI AOI Area of interest for SPI SPI-0.41
Projects
None yet
Development

No branches or pull requests

2 participants