Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch dlist up for GHC 8.8.1 #32

Closed
wants to merge 6 commits into from
Closed

Patch dlist up for GHC 8.8.1 #32

wants to merge 6 commits into from

Conversation

vmchale
Copy link

@vmchale vmchale commented Apr 12, 2019

This uses a pre-release of GHC 8.8.1

@spl
Copy link
Owner

spl commented Apr 13, 2019

Thanks! Would it be possible for you to add a test or two for fail and update the .travis.yml to include GHC 8.8.1?

@vmchale
Copy link
Author

vmchale commented Apr 13, 2019

Hmm looks like splitmix's bounds are a little too tight.

@spl
Copy link
Owner

spl commented Apr 13, 2019

@vmchale Thanks for the updates! I guess there are two options: updating splitmix or making this an “allowed failure” for Travis.

@vmchale
Copy link
Author

vmchale commented Apr 14, 2019

I think it's best to allow failures on travis - I'm not sure when splitmix will be updated!

@spl spl closed this in c9b1572 Apr 14, 2019
@spl
Copy link
Owner

spl commented Apr 14, 2019

Thanks again! I massaged the commits a bit and pushed to master.

@spl spl mentioned this pull request May 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vmchale @spl