WIP: preliminary git-annex support #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
==========================================
+ Coverage 94.58% 94.61% +0.03%
==========================================
Files 28 28
Lines 2657 2655 -2
==========================================
- Hits 2513 2512 -1
+ Misses 144 143 -1
Continue to review full report at Codecov.
|
Supysonic doesn't deal well with [git-annex][] (GA) repositories. Because GA stores files as symlinks to an object storage in `.git/annex/objects`, all the normal `Artist/Album/File.mp3` files are ignored and instead the actual files in `.git` are parsed. [git-annex]: https://git-annex.branchable.com/ Those files have funky filenames based on the file hash, for example: ``` .git/annex/objects/xm/zw/SHA256E-s1093632--6dc57e45ba7f81ed48ab6e581335bd2fb6271e40934c97931c6684cea3eec0b9.mp3/SHA256E-s1093632--6dc57e45ba7f81ed48ab6e581335bd2fb6271e40934c97931c6684cea3eec0b9.mp3 ``` This makes most Supysonic client show the garbled filename instead of the song title and breaks most album grouping behavior. This patch makes the scanner follows symlinks when scanning and ignores hidden directories (so `.git`). It's a WIP for now because ideally the parser would be rewritten to use the faster `os.walk` and support arbitrary ignore patterns or enable the user to configure whether symlinks must be followed. But I've been using this patch on my side and it works sufficiently well.
anarcat
force-pushed
the
git-annex-support
branch
from
d9daf72
to
023c9cc
Compare
spl0k
added a commit
that referenced
this pull request
Jul 6, 2019
|
that looks awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supysonic doesn't deal well with git-annex (GA)
repositories. Because GA stores files as symlinks to an object storage
in
.git/annex/objects, all the normalArtist/Album/File.mp3filesare ignored and instead the actual files in
.gitare parsed.Those files have funky filenames based on the file hash, for example:
This makes most Supysonic client show the garbled filename instead of
the song title and breaks most album grouping behavior.
This patch makes the scanner follows symlinks when scanning and
ignores hidden directories (so
.git). It's a WIP for now becauseideally the parser would be rewritten to use the faster
os.walkandsupport arbitrary ignore patterns or enable the user to configure
whether symlinks must be followed (see also #144).
But I've been using this patch on my side and it works sufficiently
well.