Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update and separate examples in Readme [ci skip] #29

Merged
merged 1 commit into from Dec 17, 2014
Merged

update and separate examples in Readme [ci skip] #29

merged 1 commit into from Dec 17, 2014

Conversation

e2
Copy link
Contributor

@e2 e2 commented Dec 17, 2014

The example in the README didn't work, so I fixed it.

Also, I separated the examples, because as one huge block it was just
overwhelming and discouraging.

splattael added a commit that referenced this pull request Dec 17, 2014
@splattael
Merge pull request #29 from e2/refactor_readme_examples
78bf15a 
update and separate examples in Readme [ci skip]
@splattael splattael merged commit 78bf15a into splattael:master Dec 17, 2014
@splattael
Copy link
Owner

Nice, thank you! 👍

splattael pushed a commit that referenced this pull request Dec 17, 2014
Delegate Libnotify.icon_dirs to Libnotify::API
3b622d6 
As mentioned in #29 the example in the README did not work.

After this commit this works again:

    Libnotify.icon_dirs << "/usr/share/icons/gnome/*/"

Thanks to @e2 for mentioning!
@e2
Copy link
Contributor Author

e2 commented Dec 17, 2014

My pleasure :)

@e2 e2 deleted the refactor_readme_examples branch December 17, 2014 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@e2 @splattael