safe option to around?

[jbodah]

I've been using around to run encapsulate some code that ran in begin...ensure blocks. Errors in teardown's however are caught by Minitest and thus the resulting ensure never runs

This feels unexpected to me. I haven't dug into it too much but my gut tells me this is because of the use of Fibers and not ensure'ing the Fiber yield

require 'test_helper'

class HelloTest < Minitest::Spec
  around do |block|
    begin
      block.call
    ensure
      puts "it worked!"
    end
  end

  after do
    raise "woops"
  end

  it "works" do
    assert true
  end
end

With output:

# Running tests with run options --seed 8681:

E

Error:
HelloTest#test_0001_works:
RuntimeError: woops
    /Users/jbodah/repos/cg-ruby-sem/test/unit/hello_test.rb:13:in `block in <class:HelloTest>'


Finished tests in 0.002105s, 475.0594 tests/s, 475.0594 assertions/s.


Slowest tests:

0.000083s test_0001_works#HelloTest

1 tests, 1 assertions, 0 failures, 1 errors, 0 skips
Coverage report generated for Unit Tests to /Users/jbodah/repos/cg-ruby-sem/artifacts/coverage. 439 / 1053 LOC (41.69%) covered.
rake aborted!
Command failed with status (1)

[grosser]

I might have run into that a few times ... can you make a PR with a failing test-case ?

…

On Thu, Nov 8, 2018 at 1:02 PM Josh Bodah ***@***.***> wrote: I've been using around to run encapsulate some code that ran in begin...ensure blocks. Errors in teardown's however are caught by Minitest and thus the resulting ensure never runs This feels unexpected to me. I haven't dug into it too much but my gut tells me this is because of the use of Fibers and not ensure'ing the Fiber yield require 'test_helper' class HelloTest < Minitest::Spec around do |block| begin block.call ensure puts "it worked!" end end after do raise "woops" end it "works" do assert true endend With output: # Running tests with run options --seed 8681: E Error: HelloTest#test_0001_works: RuntimeError: woops /Users/jbodah/repos/cg-ruby-sem/test/unit/hello_test.rb:13:in `block in <class:HelloTest>' Finished tests in 0.002105s, 475.0594 tests/s, 475.0594 assertions/s. Slowest tests: 0.000083s test_0001_works#HelloTest 1 tests, 1 assertions, 0 failures, 1 errors, 0 skips Coverage report generated for Unit Tests to /Users/jbodah/repos/cg-ruby-sem/artifacts/coverage. 439 / 1053 LOC (41.69%) covered. rake aborted! Command failed with status (1) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#32>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAsZ1n9FOc898L5VjOfNI5zSDkswlrqks5utJwAgaJpZM4YVerf> .

[jbodah]

Sure - I just dug into it a bit; the issue is actually the resume guard clause:

From: /usr/local/bundle/gems/minitest-around-0.4.1/lib/minitest/around/spec.rb @ line 23 self.around:

    18:           raise
    19:         end
    20:       end
    21:       fib.resume(self, lambda { Fiber.yield })
    22:     end
 => 23:     after  { fib.resume unless fib == :failed }
    24:   end
    25:
    26:   # Minitest does not support multiple before/after blocks
    27:   remove_method :before
    28:   def before(type=nil, &block)

[1] pry(#<MsnAccountSyncTest>)> fib == :failed
=> true