Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: reorder Dockerfile layers for better cache use #116

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Minor: reorder Dockerfile layers for better cache use #116

merged 1 commit into from
Feb 28, 2024

Conversation

jantuomi
Copy link
Contributor

Move package installs and prisma client generation to before copying the src directory into the image. Regular source code changes in src do not warrant rerunning those steps.

shynst added a commit to shynst/spliit that referenced this pull request Feb 27, 2024
@shynst
Reorder Dockerfile layers for better cache use (spliit-app#116)
6263519
justcallmelarry
justcallmelarry approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@justcallmelarry justcallmelarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can attest this works as expected 👌

@scastiel
Copy link
Member

💯

@scastiel scastiel merged commit b227401 into spliit-app:main Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justcallmelarry justcallmelarry justcallmelarry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jantuomi @scastiel @justcallmelarry