Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach documents to expenses #64

Merged
merged 4 commits into from
Jan 28, 2024
Merged

Attach documents to expenses #64

merged 4 commits into from
Jan 28, 2024

Conversation

scastiel
Copy link
Member

@scastiel scastiel commented Jan 26, 2024 •
edited

Resolves #63.

Implement receipt upload for expenses, storing them to an S3 bucket provided as an environment variable.

Todo in this PR:

  • Check the document’s type before upload
  • Activate upload feature on opt-in (using environment variables)

Todo in a future PR:

  • Handle more than images (PDF…)

@scastiel scastiel changed the title Upload documents to receipts Attach documents to expenses Jan 28, 2024
@scastiel scastiel marked this pull request as ready for review January 28, 2024 23:49
@scastiel scastiel merged commit d43e731 into main Jan 28, 2024
1 check passed
@scastiel scastiel deleted the upload-documents branch January 28, 2024 23:51
@scastiel scastiel mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to add attachment (pictures, receipts, etc) to expenses
1 participant
@scastiel