Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add Gemfile, slather test #53

Closed
wants to merge 2 commits into from
Closed

[CI] Add Gemfile, slather test #53

wants to merge 2 commits into from

Conversation

jhersh
Copy link
Member

@jhersh jhersh commented May 5, 2015

No description provided.

segiddins
segiddins reviewed May 5, 2015
View reviewed changes
circle.yml
override:
- sudo gem install cocoapods xcpretty obcd slather -N
- pod install --project-directory=Example
- bundle check --path=vendor/bundle || bundle install --path=vendor/bundle --jobs=4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the bundle check there? just bundle install should be sufficient, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think CircleCI's caching is enabled yet for OS X builds, but if it were, bundle check would make for a faster build by skipping bundle install in the event that the dependencies are cached from a previous build (and none of them changed)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle install should never hit the network if everything in the lockfile is available?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, will remove. Any idea why this is failing to build with The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation. ?

The script does run pod install immediately before building. This might be new with 0.37?

@jhersh
Copy link
Member Author

jhersh commented May 5, 2015

This is testing a fork of slather that:

  • Takes advantage of new/changed CircleCI env vars
  • Resolves github pull requests not properly displaying on Coveralls when built with CircleCI.
    • This build built on Travis displays properly. Note that it is marked as pull request #524
    • This build from the same repo on CircleCI does not display properly. It is a pull request but
      • its branch is marked as pull/526 (github's branch name)
      • it is missing its pull request number indicator
      • it is missing its CircleCI build number

@jhersh jhersh force-pushed the slather branch 2 times, most recently from 4d8afb1 to 7557714 Compare May 6, 2015 18:04
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.57% when pulling f092f68 on slather into 7702506 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.57% when pulling 98f1a40 on slather into 7702506 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.57% when pulling c541e70 on slather into 7702506 on master.

@jhersh jhersh closed this May 7, 2015
@jhersh jhersh deleted the slather branch July 13, 2015 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhersh @coveralls @segiddins