Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide/show items on double click #18

Open
wants to merge 2 commits into
base: release/0.3-melodic
Choose a base branch
from
Open

Hide/show items on double click #18

wants to merge 2 commits into from

Commits on Jan 8, 2021

  1. [Show/hide on double click] A double click hides the the children of … 

    …an item

The mechanism is to pass tree object to qt node item to be used on the double click callback.
The qt node item also receives the uuid and store it for the callback.
The callback will change the item visibility (new variable on visibility.py) and trigger a refresh, redraw.

The visibility now uses str() instead of unique_id.fromMsg to be able to compare the id that is stored on the node_item names

Also triggered the refresh/redraw for the _update_visibility_level()

Known bug: Sometimes there is a segmentation fault after the double click.
It can happens when double click is executed.
Always happens when fit is enabled and the root is double clicked to hide, then it's double clicked to show again.
The segmentation fault happens after the signal redraw slot is executed.
    @afnbor
    afnbor committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    eb8d454 View commit details
    Browse the repository at this point in the history

  2. [Show/hide on double click] bug fix of the double click then segmenta… 

    …tion fault

Now a signal is passed to the node item with QueuedConnection.
    @afnbor
    afnbor committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    d415ac5 View commit details
    Browse the repository at this point in the history