Naive write_string for OSX #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirming that abesto's fix works, at least initially. I use custom professions extensively, if I see a problem, I'll report it. |
|
Thanks for the patch, this will make OSX users very happy! Merged! |
splintermind
added a commit
that referenced
this pull request
Apr 7, 2014
Naive write_string for OSX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A naive port (read: copy-paste) of the Linux
write_stringto OSX. One difference: it uses straightmallocinstead of a remotemmap2. I have zero idea how to do that :) I took care to make sure that ifmallocreturns a pointer to an address outside the range ofVIRTADDR, the application won't blow up (didn't test it though).I've been using this for just a few minutes now, seems to work so far.
Fixes #10