Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dokuwiki proxy setting is ignored #245

Open
XANi opened this issue Oct 11, 2016 · 8 comments
Open

Dokuwiki proxy setting is ignored #245

XANi opened this issue Oct 11, 2016 · 8 comments

Comments

@XANi
Copy link

XANi commented Oct 11, 2016

dokuwki proxy setting is not propagated into dw2pdf so it is impossible to set up proxy without modyfing php files manually

@Klap-in
Copy link
Collaborator

Klap-in commented Oct 11, 2016

Related fixed issue #210, but about the QR code. There the httpclient was updated, no idea of that fits in solution for this as well.

@Klap-in
Copy link
Collaborator

Klap-in commented Nov 24, 2017

@XANi how is the last version of dw2pdf behaving? Brings that version improvements?

@Dennis-Bezold
Copy link

Are there any news here?

@Klap-in
Copy link
Collaborator

Klap-in commented Mar 26, 2022

Hi @Dennis-Bezold you tested it? What were your findings? At the moment it is not clear if it is really broken. So any description that let us allow reproducing an lacking situation is welcome. For now I assume it is working..

@Dennis-Bezold
Copy link

Dennis-Bezold commented Mar 28, 2022

Hi @Klap-in,
We're using the version 2021-07-22 of dw2pdf and 2020-07-29 "Hogfather" of dokuwiki.

The interesting part is, when I'm creating the pdf the QR Code is displayed as an red x with no errors or problems in DevTools.

But when I'm doing the export with &debughtml=html then the QR Code is displayed and available in the browser.

I'm not sure what the problem is. We're running an nginx webserver 1.14.1 on a Rocky Linux release 8.5 Server. Dokuwiki is configurated with an proxy server and able to for exmple download plugins and so on.

If you need any logfile entrys, please let me know.

@Klap-in
Copy link
Collaborator

Klap-in commented Mar 29, 2022

I have no proxy available, so I cannot test and I have very limited time.
Please could you investigate the situation yourself?
Please try to enable logging and see if you can find attempts that skip the proxy setting of DokuWiki.
https://mpdf.github.io/installation-setup/logging.html
This require some manually additions to DokuPDF (in DokuPDF.class.php), which extends Mpdf\Mpdf() class

$mpdf = new DokuPDF($this->getExportConfig('pagesize'),

See for examples the other settting below this line.

I suspect that RemoteContentFetcher does not use the proxy settings of DokuWiki.
https://github.com/splitbrain/dokuwiki-plugin-dw2pdf/blob/5d4af507a0bab1e6fa4d223fce2596de8fa0a88a/vendor/mpdf/mpdf/src/RemoteContentFetcher.php

@Klap-in
Copy link
Collaborator

Klap-in commented Apr 5, 2022

mpdf support a proxy via curl. mpdf/mpdf#1008
Maybe the settings from dokuwiki should be set for mpdf as well. Maybe the settings from the DokuWiki config can be set when initializing mpdf in dw2pdf.

@Klap-in
Copy link
Collaborator

Klap-in commented May 5, 2023

The QR code is now created locally, since #482.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants