Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy support to curl #1008

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Conversation

kakaska
Copy link
Contributor

@kakaska kakaska commented Mar 29, 2019

No description provided.

@finwe finwe added this to the 8.1 milestone Mar 29, 2019
@finwe
Copy link
Member

finwe commented Apr 3, 2019

Thanks. Can you please also add these two properties as keys to Mpdf\Config\ConfigVariables, so that they can be set while instantiating the mPDF object? Then, rebase the branch and squash the commits. Thanks!

@@ -508,6 +508,8 @@ public function __construct()
'curlAllowUnsafeSslRequests' => false,
'curlCaCertificate' => '',
'curlTimeout' => 5,
'curlProxy' => '',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use null as a default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants