Do not send empty changes to the AD backend

This fixes password changing operations: password change and user modification are two different operations on the AD backend - the user modification should not be done on password only changes.
dokuwiki · Oct 31, 2011 · 222298b · 222298b
1 parent 3a68d3c
commit 222298b
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/inc/auth/ad.class.php b/inc/auth/ad.class.php
@@ -286,11 +286,13 @@ function modifyUser($user, $changes) {
         if(isset($changes['mail'])){
             $adchanges['email'] = $changes['mail'];
         }
-        try {
-            $return = $return & $this->adldap->user_modify($user,$adchanges);
-        } catch (adLDAPException $e) {
-            if ($this->cnf['debug']) msg('AD Auth: '.$e->getMessage(), -1);
-            $return = false;
+        if(count($adchanges)){
+            try {
+                $return = $return & $this->adldap->user_modify($user,$adchanges);
+            } catch (adLDAPException $e) {
+                if ($this->cnf['debug']) msg('AD Auth: '.$e->getMessage(), -1);
+                $return = false;
+            }
         }
 
         return $return;