-
-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media Manager still not overwrite existing files (2017-02-19a) #1864
Comments
What happens if you re-save the Configuration manager? Normally Ctrl+F5 is enough in the browser.. |
Thanks for reply. Just tried re-save the Configuration Manager and Ctrl+F5 in Google Chrome, still not work.
|
Is dokuwiki.org already updated to latest release? It is still presenting the attr() as well. |
I upgraded my wiki to 2017-02-19a with upgrade plugin. |
I have the same problem on more than one system since the last update installation to DokuWiki Release 2017-02-19a "Frusterick Manners". Best regards |
Do I understand it right that in your case:
|
I'm having the same problem. If I edit L326 of fileuploaderextended.js as mentioned by OP I still cannot overwrite files.
For me, the file and browser data is updated, but file overwrites still do not work. My server is NGINX on Debian Jessie. I was able to recreate the issue in a fresh install on my desktop (using the MicroApache download option). If I disable Javascript, I can overwrite files as I'd expect. |
My ./lib/scripts/fileuploaderextended.js file on the server has a size of 11677 bytes and the md5 checksum e9c6914f84efbdbe2814aa2044086fb6. It's line 326 is: |
Now I see what you mean: At line 245 was fixed in Hotfix. Seems logically that fix at line 326 is still required. Could you test if updating both occurrences to |
For my case, both changed to |
I have replaced the "attr" in line 326 by "is" but it didn't changed anything. The problem still persists. |
I reproduce it too on a fresh install. The initial fix included in the hotfix release was not enough. |
(I have at the moment no stack for testing, so I keep asking.) In #1863 it is suggested to fix some php code in lib/media.php:307 as well
$res = media_save(
array('name' => $path,
'mime' => $mime,
'ext' => $ext),
$ns.':'.$id,
//(($INPUT->get->str('ow') == 'checked') ? true : false),
(($INPUT->get->str('ow') == 'true') ? true : false),
$auth,
'copy' Does this fix combined with the fixes at line 245 and 326 of fileuploaderextended.js help you? btw: What are steps to reproduce? There are two places to upload files... do you experience this issue at both places in DokuWiki?
|
The problem occurs at both places (in Media Manager and in Media Files pop-up). |
With both changes, overwriting works for me too:
|
Who can create a pull request with these fixes? Looking at https://github.com/splitbrain/dokuwiki/search?utf8=%E2%9C%93&q=ow The other usage spotted so far is at line 359 of inc/media.php : $INPUT->get->str('ow'). Which is fine I guess. (or |
I created the PR for this issue. BTW, I also confirmed it works. |
As #1853 said, media manager still show "File already exists. Nothing done." even the checkbox "Overwrite existing files" is checked.
lib/scripts/fileuploaderextended.js
is new version.I noticed Line326 of fileuploaderextended.js is old syntax,
So I changed it to
But still not work.
The text was updated successfully, but these errors were encountered: