Fixes messages.txt's modification timestamp not being updated. #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug occurs on systems where writing a zero-length string to an empty file does not update the file's modification timestamp. This leads to the messages.txt being downloaded almost endlessly, causing long delays for logged-in users. Visitors are not affected, because the messages.txt is only updated for logged-in users.
splitbrain
added a commit
that referenced
this pull request
May 22, 2012
Fixes messages.txt's modification timestamp not being updated.
splitbrain
added a commit
that referenced
this pull request
Apr 9, 2020
Ensure that struct output is only rendered once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug occurs on systems where writing a zero-length string to an
empty file does not update the file's modification timestamp.
This leads to the messages.txt being downloaded almost endlessly, causing
long delays for logged-in users. Visitors are not affected, because the
messages.txt is only updated for logged-in users.