added support for local style.ini files

[selfthinker]

Currently a template's style.ini file is the only thing which will get overwritten when updating. This introduces support for local style.ini files. I.e. a template's style.local.ini will take precedence over style.ini if it exists. This follows the same principle as the rest of the config files [https://www.dokuwiki.org/config#configuration_files].

[selfthinker]

Although we are in feature freeze, I would like to add this to Adora Belle. You could argue that it fixes an annoying bug... What do you think?

[splitbrain]

personally I'd rather like to see style.ini be replaced by .less variables. not sure if it makes sense to even extend this..

[selfthinker]

Yes, we discussed it a few times that we should replace our style.ini with something else. If that is LESS (like proposed in FS#2316) or something else should be discussed. But I agree that it should generally be done. And I would definitely like to see an admin interface for that!

This is not so much about extending our current functionality but about fixing it. E.g. our upgrade instructions and that an upgrade supposedly works by just overwriting everything and everything will be fine, is otherwise wrong and misleading.
And as we planned to do something about style.ini for about 3 years or so (or longer?), this intermediate solution should be worth adding.

[dom-mel]

IMHO this is a must have. It would be consistent with the other config files and enabled a more smooth updating. Even if we switch to less (would take 2 releases with deprecation?) it would still worth this patch. ;-)

[glensc]

does that style.local.ini end up in lib/tpl/ dir? or in conf/ dir? i would vote for conf/ to note everything that's configurable to be in there, like plugin_lang currently is in conf/ dir

[michitux]

As a result of the discussion we've just had in our IRC meeting it will be in the template dir for now and we might add proper config cascade support with conf/ as recommended solution in a future release (or change it to use something else).

[selfthinker]

It is too late for the current release to add local style.inis to the config cascade and/or make them available in the conf folder. That's also a bit different as each template would need its own style.ini file. So, to have something like conf/style.arctic.ini might be an option.

On the other hand we already have local configs. Why not simply add pattern replacement values to the standard template config?!? That would also solve the problem how to make them available through the admin interface!

[splitbrain]

Looks good. Any chance for a unit test of css_styleini()?

[splitbrain]

merged. but a unit test would still be nice