added support for new github api. requires github.token config item set. updated README #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 2, 2014 20:52
|
I suppose http://hub.github.com/ makes this obsolete.... :( |
| print "loading pull request info for request %s..." % (pullreq) | ||
| url = "https://api.github.com/repos/%s/pulls/%s" % (repo, pullreq) | ||
| req = urllib2.Request(url) | ||
| req = urllib2.Request( | ||
| url, headers={'User-Agent': 'Awesome-Octocat-App', 'Authorization': 'token ' + token}) |
There was a problem hiding this comment.
This should have a real Application name. Also authentication should be optional and only be needed when pulling private repository info
|
Done. The GH api returns a 404 in the case of a repo that does not exist and in the case where you attempt to access a private repo without a token. I attempt to get a a token every run, proceed if it doesn't exist and hint at adding one if we get a 404. I also attempted to deal with missing remotes more gracefully |
splitbrain
added a commit
that referenced
this pull request
Apr 30, 2014
added support for new github api. requires github.token config item set. updated README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.