Upgrade DataFusion to 12 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily use a fork of convergence with the upgraded DF as well. Remove the object_store patch (since DF now uses 0.5.0), will see if it still has that weird Minio signature issue.
- `datafusion::logical_plan` is now deprecated, use `datafusion_expr`,
`datafusion::common` as required
- use `ParquetRecordBatchReader`
- Apply changes to the DF's `CREATE EXTERNAL TABLE` functionality. It now
allows to pass in custom table formats, which isn't useful for us since
we don't want people to have to do `STORED AS SEAFOWL` for every table.
Stub that functionality out.
They do change with Arrow version changes (which we should probably solve to avoid data duplication), but right now we test IDs in other tests as well and it's difficult to maintain these object store tests with ID changes.
- Fix missing `SHOW TABLES` - Actually inject the changed HTTP URL back into `CreateExternalTable` - Factor out some object IDs into constants and fix those changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes #112 and upgrades to object_store 0.5.0.