Various fixes for sgr cloud CLIs #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `sgr csv import`, we load data using `COPY FROM STDIN` which doesn't let us treat empty strings as NULLs, whereas with the CSV FDW we can do that. To get around this, we use the empty strings in the type inference in the former case (so that integer columns with empty strings still end up as VARCHARs).
Elaborate on needing to edit the `splitgraph.yml` file
It would ignore the list of repos to limit the load to; fix by filtering the repos in any case.
- use "ephemeral" instead of cte for materialization The sample job in the suite at https://github.com/mildbyte/template-test-2/runs/4667663552?check_suite_focus=true now actually completes (but doesn't do anything) because it just makes an unchecked CTE (the source tables don't exist). Fails as expected (https://github.com/mildbyte/template-test-2/runs/4667687824?check_suite_focus=true) if we materialize as tables since then the relation indeed doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things that cropped up during manual testing of the project seed workflow